feat: add safe diagnostics export

2026-09-07 18:49:53 +07:00
parent 6477681e41
commit fa3b24fb1f
5 changed files with 35 additions and 5 deletions
@@ -89,7 +89,13 @@ def test_admin_diagnostics_exposes_build_identity_only_to_admin() -> None:
    assert client.get("/api/v1/admin/diagnostics").status_code == 401
    response = client.get("/api/v1/admin/diagnostics", headers={"Authorization": "Bearer change-me-in-production"})
    assert response.status_code == 200
-    assert response.json() == {"version": "0.1.0", "revision": "dev", "environment": "development"}
+    payload = response.json()
+    assert payload["build"] == {"version": "0.1.0", "revision": "dev", "environment": "development"}
+    assert set(payload) == {"generated_at", "build", "counts"}
+    assert response.headers["Content-Disposition"] == "attachment; filename=rf4spotter-diagnostics.json"
+    serialized = response.text.lower()
+    for forbidden in ("player_name", "source_url", "error_summary", "raw_payload", "admin_token", "s3_"):
+        assert forbidden not in serialized


 def test_spot_detail_and_catches() -> None: