test: centralize media role labels

apps/web/src/components/EntityMedia.astro

@@ -1,8 +1,8 @@
 ---
 import SourceBadge from "./SourceBadge.astro";
 import type { MediaAsset } from "../lib/api";
+import { mediaRoleLabel } from "../lib/media";
 const { asset, compact = false, sourceLink = false } = Astro.props as { asset: MediaAsset; compact?: boolean; sourceLink?: boolean };
-const roleLabels: Record<string, string> = { waterbody_cover: "Заставка водоёма", waterbody_map: "Карта водоёма", waterbody_depth_map: "Карта глубин", waterbody_screenshot: "Скриншот водоёма", tackle_card: "Карточка снасти", tackle_detail: "Деталь снасти", rig_diagram: "Схема монтажа", tackle_screenshot: "Скриншот снасти" };
 ---
 <figure class:list={["entity-media", { "entity-media--compact": compact }]}>
   <span class="entity-media__frame"><picture>
@@ -12,5 +12,5 @@ const roleLabels: Record<string, string> = { waterbody_cover: "Заставка
     })}
     <img src={asset.image_url} alt={asset.label ?? "Иллюстрация RF4"} width={asset.width} height={asset.height} loading="lazy" decoding="async" />
   </picture></span>
-  <figcaption><SourceBadge source={asset.source_system} href={sourceLink ? asset.source_url : undefined} /><span>{asset.label ?? "Справочный материал"}</span>{asset.media_role && <small data-media-role={asset.media_role}>{roleLabels[asset.media_role] ?? asset.media_role}</small>}</figcaption>
+  <figcaption><SourceBadge source={asset.source_system} href={sourceLink ? asset.source_url : undefined} /><span>{asset.label ?? "Справочный материал"}</span>{asset.media_role && <small data-media-role={asset.media_role}>{mediaRoleLabel(asset.media_role)}</small>}</figcaption>
 </figure>

apps/web/src/lib/media.ts

@@ -1,5 +1,18 @@
 import type { MediaAsset, MediaRole } from "./api";
 
+const mediaRoleLabels: Record<MediaRole, string> = {
+  waterbody_cover: "Заставка водоёма",
+  waterbody_map: "Карта водоёма",
+  waterbody_depth_map: "Карта глубин",
+  waterbody_screenshot: "Скриншот водоёма",
+  tackle_card: "Карточка снасти",
+  tackle_detail: "Деталь снасти",
+  rig_diagram: "Схема монтажа",
+  tackle_screenshot: "Скриншот снасти",
+};
+
+export const mediaRoleLabel = (role: string): string => mediaRoleLabels[role as MediaRole] ?? role;
+
 const tokens = (value: string) => value
   .toLocaleLowerCase("ru")
   .replaceAll("ё", "е")

apps/web/tests/unit/presentation.test.ts

@@ -7,7 +7,7 @@ import { tackleVisualKind, tackleVisualTone } from "../../src/lib/tackle-visuals
 import { waterbodyVisual } from "../../src/lib/waterbody-visuals.ts";
 import { pageHref, pageWindow } from "../../src/lib/pagination.ts";
 import { adminEndsSession, adminErrorMessage } from "../../src/lib/admin-errors.ts";
-import { findMediaByLabel } from "../../src/lib/media.ts";
+import { findMediaByLabel, mediaRoleLabel } from "../../src/lib/media.ts";
 
 test("activity levels share one complete 0-100 scale", () => {
   assert.deepEqual(
@@ -79,6 +79,14 @@ test("waterbody media lookup only accepts reviewed roles when constrained", () =
   assert.equal(findMediaByLabel([...assets], "Куори", ["waterbody_cover"]), undefined);
 });
 
+test("reviewed media roles keep human-readable labels with a safe fallback", () => {
+  assert.deepEqual(
+    ["waterbody_cover", "waterbody_map", "waterbody_depth_map", "waterbody_screenshot", "tackle_card", "tackle_detail", "rig_diagram", "tackle_screenshot"].map(mediaRoleLabel),
+    ["Заставка водоёма", "Карта водоёма", "Карта глубин", "Скриншот водоёма", "Карточка снасти", "Деталь снасти", "Схема монтажа", "Скриншот снасти"],
+  );
+  assert.equal(mediaRoleLabel("future_role"), "future_role");
+});
+
 test("45 records are reachable across three stable pages", () => {
   const pages = [pageWindow(45, 20, 0), pageWindow(45, 20, 20), pageWindow(45, 20, 40)];
   assert.deepEqual(pages.map(page => [page.start, page.end]), [[1, 20], [21, 40], [41, 45]]);