fix: make bulk observation rejection atomic

2026-09-21 20:27:45 +07:00
parent 1ac27986cb
commit 1dbda03209
2 changed files with 7 additions and 3 deletions
@@ -61,13 +61,16 @@ def suggest_aliases(session: Session, observation: ExternalObservation) -> tuple
    return (fish_alias.fish if fish_alias else None, waterbody_alias.waterbody if waterbody_alias else None)


-def reject_observation(session: Session, observation: ExternalObservation, *, reason: str) -> ExternalObservation:
+def reject_observation(
+    session: Session, observation: ExternalObservation, *, reason: str, commit: bool = True,
+) -> ExternalObservation:
    if observation.status == "published":
        raise ExternalReviewError("published observation cannot be rejected")
    observation.status = "rejected"
    observation.review_note = reason
    observation.reviewed_at = datetime.now(timezone.utc)
-    session.commit()
+    if commit:
+        session.commit()
    return observation