refactor: assign submissions to dedicated router

apps/api/app/main.py

@@ -29,6 +29,7 @@ from .readiness import readiness_report
 from .routers.activity import router as activity_router
 from .routers.catalog import router as catalog_router
 from .routers.public_data import router as public_data_router
+from .routers.submissions import router as submissions_router
 from .public_cache import public_cache
 from .schemas import ActivityOut, AdminCatchReportOut, CatchReportAccepted, CatchReportCreate, CatchReportCreated, ExternalAliasSuggestionOut, ExternalObservationDecision, ExternalObservationMapping, ExternalObservationOut, ExternalObservationPublished, ImportRunOut, ModerationUpdate
 from .storage import ScreenshotError, client as storage_client, delete_screenshot, signed_screenshot_url, upload_screenshot
@@ -255,7 +256,7 @@ def admin_reject_external_observation(
         raise HTTPException(status_code=409, detail=str(exc)) from exc
 
 
-@app.post("/api/v1/catch-reports", response_model=CatchReportAccepted, status_code=201)
+@submissions_router.post("/api/v1/catch-reports", response_model=CatchReportAccepted, status_code=201)
 def create_catch_report(
     payload: CatchReportCreate, request: Request, db: Db,
     idempotency_key: Annotated[str | None, Header()] = None,
@@ -331,7 +332,7 @@ def create_catch_report(
     return CatchReportAccepted(id=report.id, moderation_status=report.moderation_status.value, screenshot_upload_token=upload_token, idempotent=False)
 
 
-@app.post("/api/v1/catch-reports/{report_id}/screenshot", status_code=204, response_class=Response)
+@submissions_router.post("/api/v1/catch-reports/{report_id}/screenshot", status_code=204, response_class=Response)
 def add_screenshot(
     report_id: UUID, db: Db, screenshot: UploadFile = File(),
     upload_token: Annotated[str | None, Header(alias="X-Upload-Token")] = None,
@@ -354,6 +355,9 @@ def add_screenshot(
     return Response(status_code=204)
 
 
+app.include_router(submissions_router)
+
+
 @app.get("/api/v1/admin/catch-reports", response_model=list[AdminCatchReportOut])
 def admin_reports(db: Db, _: Annotated[str, Depends(_admin)], status: ModerationStatus = ModerationStatus.pending, limit: int = Query(50, ge=1, le=100), offset: int = Query(0, ge=0)) -> list[AdminCatchReportOut]:
     reports = list(db.scalars(select(CatchReport).options(joinedload(CatchReport.fish), joinedload(CatchReport.waterbody), joinedload(CatchReport.spot), joinedload(CatchReport.bait)).where(CatchReport.source_type == SourceType.user, CatchReport.moderation_status == status, CatchReport.deleted_at.is_(None)).order_by(CatchReport.reported_at, CatchReport.id).offset(offset).limit(limit)))

apps/api/app/routers/submissions.py

@@ -0,0 +1,3 @@
+from fastapi import APIRouter
+
+router = APIRouter()